Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to register menubar plugins #644

Merged
merged 4 commits into from
May 28, 2015

Conversation

astrofrog
Copy link
Member

In some cases we might want to create plugins that are not tied to a specific GUI action. For instance, I am writing a small plugin that can be used to reorder components in a categorical component. Another example would be a plugin to edit data types of components. This sets up the framework to register plugins in a 'Tools' menu. We could also allow plugins to be added to any existing menu rather than defining a new one. @ChrisBeaumont - what do you think?

screen shot 2015-05-28 at 3 33 11 pm

@astrofrog
Copy link
Member Author

I think the failure in Travis is unrelated and due to a change in package versions available in conda

@ChrisBeaumont - any objections to merging this as is for now? I know that a few people at STScI are interested in making some plugins as part of a sprint, so would be nice to have that.

@ChrisBeaumont
Copy link
Member

I'm on vacation / getting married this weekend, so I don't have time to
review this before next week. Feel free to merge in the meantime, else I'll
take a look Monday.

On Thursday, May 28, 2015, Thomas Robitaille notifications@github.com
wrote:

I think the failure in Travis is unrelated and due to a change in package
versions available in conda

@ChrisBeaumont https://github.com/ChrisBeaumont - any objections to
merging this as is for now? I know that a few people at STScI are
interested in making some plugins as part of a sprint, so would be nice to
have that.


Reply to this email directly or view it on GitHub
#644 (comment).

@astrofrog
Copy link
Member Author

Oh of course please don't worry about it now!!

In the mean time, have a great weekend! 🎉 🎉 🎉

@astrofrog
Copy link
Member Author

I'm going to go ahead and merge this and open an issue milestoned as 0.5 to remind us to re-examine this before releasing glue 0.5

astrofrog added a commit that referenced this pull request May 28, 2015
Added the ability to register menubar plugins
@astrofrog astrofrog merged commit 9029c13 into glue-viz:master May 28, 2015
@astrofrog
Copy link
Member Author

The Travis failures are unrelated and due to something to do with the libpng version installed by conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants