Use latest version of qt-helpers #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, this is also a first step to getting glue working with PyQt5 (but a few more changes will be needed) |
astrofrog
force-pushed
the
use-qt-helpers
branch
from
bbe438d
to
43e56dd
Compare
|
@ChrisBeaumont - does this seem ok to you? (mainly the change relating to |
|
The coverage stats appear to be erratic because the file I added should be excluded anyway, so I think we can count this as passing :) |
|
Looks good |
astrofrog
added a commit
that referenced
this pull request
Jun 29, 2015
Use latest version of qt-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only potentially controversial change here is that before, when importing glue, an application instance was started and was given the glue icon. However, now the icon is set only when starting up the actual glue application. This means that other packages importing from Glue won't automatically be branded with the glue icon, which I think makes sense (but note that importing glue still starts up the QApplication instance).