Fix plugin loading #699
Merged
Fix plugin loading #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we warn users at setuptools-import-time if their version is too old? Should we add an old version of setuptools to the travis build matrix? |
|
@ChrisBeaumont - to be honest I'm having trouble finding a version that's not compatible. I went all the way down to 0.6 and it still worked. Having said that, we could simply make one of the existing builds use setuptools 0.6 for example (no need to add a new build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #697, we found that plugins don't get loaded for setuptools < 11.3. This fixes compatibility, and plugin loading now works for setuptools >= 0.6.