Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to image viewer to allow aspect ratio to be toggled between auto and equal #717

Merged
merged 1 commit into from
Aug 24, 2015
Merged

Add an option to image viewer to allow aspect ratio to be toggled between auto and equal #717

merged 1 commit into from
Aug 24, 2015

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog added this to the 0.6 milestone Aug 21, 2015
@astrofrog
Copy link
Member Author

Done! Here's what it looks like:

screen shot 2015-08-21 at 8 59 56 pm

cc @jegpeek

@jegpeek
Copy link

jegpeek commented Aug 21, 2015

awesome!!

-Josh

On Fri, Aug 21, 2015 at 3:00 PM, Thomas Robitaille <notifications@github.com

wrote:

Done! Here's what it looks like:

[image: screen shot 2015-08-21 at 8 59 56 pm]
https://cloud.githubusercontent.com/assets/314716/9416722/9b2cf3fa-4847-11e5-83ba-4a7bb85bad1d.png

cc @jegpeek https://github.com/jegpeek

—
Reply to this email directly or view it on GitHub
#717 (comment).

Dr. Joshua E G Peek
Assistant Astronomer, Space Telescope Science Institute
Adjunct Research Scientist, Columbia University

STScI: 1 410 338 4561
Mobile: 1 510 299 4427

ChrisBeaumont
ChrisBeaumont reviewed Aug 24, 2015
View reviewed changes
glue/qt/widgets/image_widget.py
@@ -74,6 +76,9 @@ def _setup_widgets(self):
self.ui.slice_layout.addWidget(self.ui.slice)
self._tweak_geometry()

self.ui.aspectCombo.addItem("Square Pixels", userData='equal')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had some issues with the behavior of userData across different Qt bindings, though I don't remember the details. It's fine to leave this for now, but we should keep this in mind in case we see bug reports in the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok - I'll keep an eye out for issues there.

@ChrisBeaumont
Copy link
Member

Cool, looks good.

@astrofrog
Copy link
Member Author

Thanks!

astrofrog added a commit that referenced this pull request Aug 24, 2015
@astrofrog
Merge pull request #717 from astrofrog/imshow-aspect-ratio
963c54b 
Add an option to image viewer to allow aspect ratio to be toggled between auto and equal
@astrofrog astrofrog merged commit 963c54b into glue-viz:master Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Ready for final review
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@astrofrog @jegpeek @ChrisBeaumont