Fix categorical selection #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test for categorical scatter plot selection.
| else: | ||
| subset = RangeSubsetState(lo, hi, self.xatt) | ||
| subset = RangeSubsetState(lo, hi, self._get_attribute(coord)) |
There was a problem hiding this comment.
Just for info, this was part of the bug (it was always selecting on x-axis)
|
Bugfixes look reasonable to me |
|
@ChrisBeaumont - thanks for reviewing! |
astrofrog
added a commit
to astrofrog/glue
that referenced
this pull request
Aug 26, 2015
Fix categorical selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JudoWill @ChrisBeaumont - this is an immediate fix for the selection in scatter plots with rectangular selections when categorical ROI are present.
I would like to merge this pretty soon and release 0.5.3, since this is a reasonably big bug, and #692 could then go in 0.6.