Tidy up FITS and HDF5-related code #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
tidy-fits-hdf5
branch
from
28579b9 to
9ca4398
Compare
astrofrog
force-pushed
the
tidy-fits-hdf5
branch
from
9ca4398 to
1d33c23
Compare
astrofrog
force-pushed
the
tidy-fits-hdf5
branch
from
f871471 to
b084b27
Compare
astrofrog
changed the title
|
@ChrisBeaumont - sorry, the diff is not super easy to read. The main change is that when loading HDF5 files, all the gridded datasets and tables are now read in. I then also tidied things around, separating deprecated functions from the rest. |
|
LGTM |
astrofrog
added a commit
that referenced
this pull request
Oct 6, 2015
Tidy up FITS and HDF5-related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, code relating to FITS and HDF5 factories is spread over several files. This creates
glue.core.data_factories.fitsandglue.core.data_factories.hdf5but for now I've tried to ensure that this remains backward-compatible.Remaining to-dos:
Rename 'casalike' to 'spectral_cube'- will do in separate PR