Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PySide segfault #771

Closed
wants to merge 2 commits into from
Closed

Fix PySide segfault #771

wants to merge 2 commits into from

Conversation

astrofrog
Copy link
Member

Use _find_combo_data instead of findData, because PySide crashes if the data is not a string

Closes #770

@astrofrog
Copy link
Member Author

Ironically, the failure here is due, I think, to the bugs that #755 fixes :)

@astrofrog astrofrog modified the milestone: 0.6 Oct 22, 2015
@ChrisBeaumont
Copy link
Member

👍 as I mentioned elsewhere, we could think about patching the findData method directly, so we are less likely to hit this again in the future

@astrofrog
Copy link
Member Author

Fixed in #755

@astrofrog astrofrog closed this Oct 22, 2015
@astrofrog astrofrog deleted the fix-pyside-segfault branch May 5, 2016 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants