Finish re-organizing files from glue.qt #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y run get_qapp anymore (just make sure it’s always run when needed, for example when running tests or initializing the GlueApplication)
|
LGTM -- my only concern would be whether the inkscape -> png translation is adding any weirdness that the illustrator -> png translation didn't. The current PNGs in this branch look good -- were they regenerated from the new SVGs? |
|
@ChrisBeaumont - no, but I could re-generate them just to compare. |
|
Here's a view of the differences: astrofrog@7d242ef - I just noticed an artifact in glue_or.svg which I'll remove here. Some of the colors have changed slightly, so I'll see if I can tweak that too. |
|
Now looks better: astrofrog@1b192b2 |
astrofrog
added a commit
that referenced
this pull request
Feb 3, 2016
Finish re-organizing files from glue.qt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the reorganization of files from glue.qt and removes the glue.qt submodule for now (as indicated in #841 we can then decide to add it back with some compatibility imports if we want to deprecate any of the imports over one version).
The reason for the large diff numbers is that I've removed the Adobe Illustrator file for the icons, replacing it with SVG icons.