Add a helper to link widgets related to setting limits #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisBeaumont - if you have a chance to take a look at this in the next couple of days, it would be great to have your feedback about this approach. Essentially the general question is how to link sets of widgets together via some logic - another common case would be a QSlider + QLineEdit, which could benefit from a similar class. |
astrofrog
force-pushed
the
attribute-limits-helper
branch
from
c48212d
to
f6ebb86
Compare
…r attribute combos and lower/upper level values, with support for optionally having a combo to set the automatic scaling mode.
…intricately related to the limits.
… subset_mode=‘outline’
…her attribute limits helpers
astrofrog
force-pushed
the
attribute-limits-helper
branch
from
f6ebb86
to
78a13c8
Compare
astrofrog
added a commit
that referenced
this pull request
Mar 18, 2016
Add a helper to link widgets related to setting limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a number of widgets, we need to implement the logic of caching attribute limits for different data attributes, linking an autoscaling option to the limits, flipping the limits, etc. This PR adds a helper class to manage this in one place.
This is an alternative to #871 - the advantage of the helper class is that it does not impose any particular layout (whereas the layout in #871 did not always fit in to particular widgets). It also allows some of the things, such as the scale mode and flip button, to be optional.
An example of using this is in glue-viz/glue-vispy-viewers#83 - in particular, note that the Python files there are significantly simplified.
The helper here can also be used inside Glue core in various places, such as the image layer artist editor, or histogram limits for instance.