Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when pvextracting #901

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Crash when pvextracting #901

merged 1 commit into from
Mar 29, 2016

Conversation

keflavich
Copy link
Contributor

I tried pvextraction on a particular file (ask and I'll send a link) and it crashed with this error:

Traceback (most recent call last):
  File "/Users/adam/repos/glue/glue/viewers/common/qt/mpl_widget.py", line 113, in paintEvent
    self.roi_callback(self)
  File "/Users/adam/repos/glue/glue/core/qt/roi.py", line 41, in _paint_check
    self.paint(canvas)
  File "/Users/adam/repos/glue/glue/core/qt/roi.py", line 45, in paint
    self.draw_polygon(canvas, x, y)
  File "/Users/adam/repos/glue/glue/core/qt/roi.py", line 97, in draw_polygon
    p = self.get_painter(canvas)
  File "/Users/adam/repos/glue/glue/core/qt/roi.py", line 86, in get_painter
    p.setBrush(Qt.NoBrush)
NameError: name 'Qt' is not defined
QWidget: It is dangerous to leave painters active on a widget outside of the PaintEvent
QPainter::begin: A paint device can only be painted by one painter at a time.
Segmentation fault: 11

version is glueviz==0.8.0.dev26152615

@astrofrog
Copy link
Member

Duplicate of #892 - could you try fixing the missing import and seeing if that works? (from glue.external.qt.QtCore import Qt) - and if so can you open a PR?

@keflavich
Copy link
Contributor Author

@astrofrog done, and it fixes the problem. I included the "closes" tags in the commit.

@astrofrog
Copy link
Member

Thanks! I'll add a changelog entry (needs a new 0.7.1 section)

@astrofrog astrofrog merged commit f4678af into glue-viz:master Mar 29, 2016
@keflavich keflavich deleted the issue892 branch March 29, 2016 23:39
@astrofrog astrofrog mentioned this pull request Mar 29, 2016
astrofrog added a commit that referenced this pull request Mar 29, 2016
astrofrog added a commit that referenced this pull request Mar 30, 2016
astrofrog added a commit that referenced this pull request Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants