-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join on multiple keys #974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
join-on-key-multiple
branch
from
May 2, 2016 19:58
fce3fab
to
698d12a
Compare
astrofrog
force-pushed
the
join-on-key-multiple
branch
from
July 20, 2016 18:37
698d12a
to
c1366da
Compare
Note that at the moment this is not going to be backward-compatible in terms of loading save files. |
astrofrog
force-pushed
the
join-on-key-multiple
branch
from
August 6, 2016 10:44
69e5847
to
d4cf820
Compare
…d to Data.join_on_key
astrofrog
force-pushed
the
join-on-key-multiple
branch
from
August 7, 2016 09:15
d4cf820
to
4cc3014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized today that we can solve the linking case described in #958 by extending
join_on_key
to support linking on pairs, triplets, and n-tuples of components rather than just single components. The current PR implements a very rough (and very slow) version of that, just to test the concept. If things work well, then I can work on a way to make the calculation of the masks much faster. Here's an example in use:We have a position-position-velocity cube and a second moment map (on the same celestial pixel scale).
Selecting in the linewidth histogram will now highlight pixels in the image.
Note that the fact the pixel axes have different naming conventions needs to be fixed (see #959)
@ChrisBeaumont - do you have any thoughts on this approach so far?