Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a proper preferences dialog and implement options for background/foreground color #988

Merged
merged 23 commits into from
May 20, 2016

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented May 17, 2016

This replaces the current Edit settings by a fully-fledged preferences dialog. Plugins can now register preference panes that add a tab to the Preferences dialog.

screen shot 2016-05-17 at 5 26 37 pm

This also adds the ability to set the background and foreground color for the built-in viewers. Here's an example:

screen shot 2016-05-17 at 5 31 11 pm

Remaining to-dos:

  • Add changelog entry
  • Check that things work properly for the custom viewers
  • Add tests for new code added here (including to make sure that existing viewers and new viewers have their colors set correctly)
  • Default color setting appears to be broken
  • Save settings to disk
  • Check that dendrogram viewer still works
  • Use weak ref for callbacks (no longer relevant)
  • Add preference panes docs

After this pull request:

  • Adjust the 3D viewers to also recognize the settings and when they are updated.
  • Document how viewers should react to changes in the visual settings
  • Add sections in settings
  • Properly detect which settings have changed in Preferences window

cc @PennyQ, just for info

@astrofrog astrofrog force-pushed the preferences-dialog branch 2 times, most recently from 05c7ead to d56bbd2 Compare May 18, 2016 17:57
…references being kept to axes even once they are closed, and dealing with that is messy. Instead, the application is responsible for looping over all viewers and changing the settings.
@astrofrog astrofrog merged commit 0ab0257 into glue-viz:master May 20, 2016
@astrofrog astrofrog added this to the 0.8.0 milestone May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant