-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a proper preferences dialog and implement options for background/foreground color #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
preferences-dialog
branch
2 times, most recently
from
May 18, 2016 17:57
05c7ead
to
d56bbd2
Compare
…r and transparency preferences
…ne for the Plotly plugin
…references being kept to axes even once they are closed, and dealing with that is messy. Instead, the application is responsible for looping over all viewers and changing the settings.
…t easier to patch them during tests.
… when changed through the preferences.
astrofrog
force-pushed
the
preferences-dialog
branch
from
May 20, 2016 14:35
976e9ef
to
d4851de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the current Edit settings by a fully-fledged preferences dialog. Plugins can now register preference panes that add a tab to the Preferences dialog.
This also adds the ability to set the background and foreground color for the built-in viewers. Here's an example:
Remaining to-dos:
Use weak ref for callbacks(no longer relevant)After this pull request:
cc @PennyQ, just for info