fix(check): Subsume implicit functions with forall correctly #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is another error in #686 as well which might be a compiler error but I am not sure yet (a type signature might be able to work around it). |
The previous, naive subsume_implicit function did not traverse the functions simultaneously so the implicit arguments would be lost if the left side had a `forall` at the top. Fixes an issue found in gluon-lang#686 cc @Etherian
Were getting a 173 Mb gluon_repl binary instead of 17Mb
<a name="v0.11.1"></a> ### v0.11.1 (2019-02-13) #### Bug Fixes * Don't build release artifacts with full debug info ([fe93583](gluon-lang@fe93583)) * **check:** Subsume implicit functions with forall correctly ([6de5c25](gluon-lang@6de5c25))
Marwes
force-pushed
the
implicit-field
branch
from
f100fe3
to
375a6ac
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 13, 2019
688: fix(check): Subsume implicit functions with forall correctly r=Marwes a=Marwes The previous, naive subsume_implicit function did not traverse the functions simultaneously so the implicit arguments would be lost if the left side had a `forall` at the top. Fixes an issue found in #686 cc @Etherian Co-authored-by: Markus Westerlind <marwes91@gmail.com>
Build succeeded |
6 tasks
bors bot
added a commit
that referenced
this pull request
May 4, 2019
686: [WIP] feat(std): add monad transformer interface, StateT, and LazyT r=Marwes a=Etherian ## Description Adds a monad-transformer interface `Transformer`, a State monad transformer `StateT`, and a Lazy monad transformer `LazyT` to the standard library. ## Related PRs Lays groundwork for Streamlike and the new parser #687. ## Status **In Development** ### Outstanding design questions - [x] ~~Can and should `StateT` be replaced by the effects system?~~ ([not for the time being, at least](#686 (comment))) - [ ] Should `Transformer` require `monad` field? - [ ] Should StateT and LazyT (and other monad transformers) be merged with their non-transformer counterparts? ### To Do - [x] ~~Fix StateT's implicit parameter bugs~~ (#688 & #689) - [ ] add tests - [ ] add inline docs ## Prior Art - StateT - [Haskell](https://hackage.haskell.org/package/transformers-0.5.6.2/docs/src/Control.Monad.Trans.State.Lazy.html#StateT) - [Idris](https://github.com/idris-lang/Idris-dev/blob/master/libs/base/Control/Monad/State.idr) - [Implementing Applicative (<*>) for StateT](https://stackoverflow.com/questions/27903650/implementing-applicative-for-statet) - MonadTrans - [Haskell](https://hackage.haskell.org/package/transformers/docs/src/Control.Monad.Trans.Class.html#MonadTrans) - [Idris](https://github.com/idris-lang/Idris-dev/blob/master/libs/base/Control/Monad/Trans.idr) Co-authored-by: Etherian <etherain@gmail.com> Co-authored-by: Markus Westerlind <marwes91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous, naive subsume_implicit function did not traverse the
functions simultaneously so the implicit arguments would be lost if the
left side had a
forallat the top.Fixes an issue found in #686
cc @Etherian