Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More performance improvements #776

Merged
merged 27 commits into from
Sep 2, 2019
Merged

More performance improvements #776

merged 27 commits into from
Sep 2, 2019

Conversation

Marwes
Copy link
Member

@Marwes Marwes commented Aug 14, 2019

No description provided.

@Marwes Marwes force-pushed the perf branch 2 times, most recently from a52713c to e70203d Compare August 17, 2019 19:31
@Marwes
Copy link
Member Author

Marwes commented Aug 21, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 21, 2019
@bors @Marwes
Merge #776 #778
2a57331 
776: More performance improvements r=Marwes a=Marwes



778: fix: Don't depend on ansi_term in windows to make windows 7 work r=Marwes a=Marwes

Fixes #777

Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 21, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Aug 21, 2019
@bors @Marwes
Merge #776
592e600 
776: More performance improvements r=Marwes a=Marwes



Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 21, 2019

Build failed

@Marwes
refactor(check): Avoid unnecessary recursion
c2d14e5
@Marwes
refactor(check): Generate more straightforward code for subsumption
06ef80d
@Marwes
perf(check): Only add implicit fields if the binding is implicit
da861eb 
When encountering a binding we no longer recurse through the entire
record but instead only do it as long as we are in a implicit binding
already. Thus adding `Applicative` also adds its `Functor` field since
`Applicative` is implicit. However, for a normal record such as from
`let int = import! std.int` we no longer recurse and add all the
implicit instances in `std.int`, instead a `let int @ { ? }` is
required.

BREAKING CHANGE
@Marwes
perf: Avoid computing the plain name in name_eq (-3%)
a7ac9f8
@Marwes
perf: Only mark types with unbound generics as HAS_GENERICS
3d835a8
@Marwes
perf: Avoid recursion in implicits.rs
89eb836
@Marwes
Unknown
d69a52e
@Marwes
perf(check): Avoid looking through metadata when checking for an impl…
4a3662e 
…icit type
@Marwes
perf: Avoid RefCell in Fixed* structurs (-1%)
de32dbd
@Marwes
perf(check): Narrow down the implicit parititioning further (-10%)
a9c965b
@Marwes
perf(check): Only do one lookup/insertion on the implicit definition map
0ea13ff
@Marwes
perf(check): Only initialize the variable generator when it is necess…
793b658 
…ary (-3%)
@Marwes
perf(vm): Avoid tracing global values unless we are in the root gc (-7%)
48a5313 
The global state only contains values from the root gc
@Marwes
perf: Shrink Type's size to 48 bytes (from 64)
178180f
@Marwes
perf(parser): Simplify tokenization iterators
c7061c7
@Marwes
perf(parser): Shrink the Token type and remove it's need to Drop
3016f25
@Marwes
perf: Only do one hash lookup when creating a Symbol
a709c71
@Marwes
refactor(check): Simplify union
78967bd
@Marwes
perf(check): Remove some branches in the occurs check¨
03e7c3b
@Marwes
perf(check): No need to lookup the type again before querying the level
5e4efe3
@Marwes
perf(check): Remove redundant operations in union
f3d4203
@Marwes
perf(check): Use RefCell::get_mut when possible
1244143
@Marwes
refactor: Construct the more specific type during unification
fa6ab66
@Marwes
Copy link
Member Author

Marwes commented Aug 31, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 31, 2019
@bors @Marwes
Merge #776
e6d6037 
776: More performance improvements r=Marwes a=Marwes



Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2019

Build failed

@Marwes
Copy link
Member Author

Marwes commented Sep 2, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 2, 2019
@bors @Marwes
Merge #776
a507ed0 
776: More performance improvements r=Marwes a=Marwes



Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 2, 2019

Build succeeded

@bors bors bot merged commit 32b1f82 into gluon-lang:master Sep 2, 2019
@Marwes Marwes deleted the perf branch September 2, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Marwes