Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoSave property and merge adjacent pieces with same decoration #140

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

jperedadnr
Copy link
Collaborator

Fixes #134
Fixes #139

Copy link
Collaborator

@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR works well. Although, there is a penalty to the performance of the control when "AutoSave" feature is switched on and it is clearly visible as a user.

Performance could be tuned in the future and currently not a blocker.

@jperedadnr
Copy link
Collaborator Author

Yes, indeed, that's why the property is set to false by default.

@jperedadnr jperedadnr merged commit 4f2f45c into gluonhq:master Apr 1, 2022
@jperedadnr jperedadnr deleted the 134-autosave branch April 1, 2022 09:12
jperedadnr pushed a commit to jperedadnr/rich-text-area that referenced this pull request Jul 11, 2023
* Style chat closer to original client

* Replace Signal with Wave

* Return "Signal" for "Signal Settings"

* Add new graphi to login screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoration model too verbose? How to listen for changes
2 participants