-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use Java and JavaFX 20 #619
Merged
abhinayagarwal
merged 10 commits into
gluonhq:master
from
Oliver-Loeffler:issue-617-actions
Apr 18, 2023
Merged
build: Use Java and JavaFX 20 #619
abhinayagarwal
merged 10 commits into
gluonhq:master
from
Oliver-Loeffler:issue-617-actions
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in test due to missing script engine.
4 tasks
AlmasB
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the 1 comment, the rest looks fine
kit/src/test/resources/com/oracle/javafx/scenebuilder/kit/fxom/HeaderWithNotOnlyImports.fxml
Show resolved
Hide resolved
4 tasks
abhinayagarwal
changed the title
build: Updated Github Actions Workflows to use JavaFX 20 and Java 20.
build: Use Java and JavaFX 20
Apr 18, 2023
abhinayagarwal
approved these changes
Apr 18, 2023
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Github Actions Workflows to use JavaFX 20 and Java 20.
Issue
Fixes #617
Progress
The workflows did not run yet, so it can happen that for the one or other workflows errors occur. I will run tests locally on Ubuntu and Windows accordingly, Mac test only for x86.