Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Note Names #139

Closed
peavine opened this issue Mar 26, 2018 · 6 comments
Closed

Duplicate Note Names #139

peavine opened this issue Mar 26, 2018 · 6 comments
Labels

Comments

@peavine
Copy link

peavine commented Mar 26, 2018

If I rename a note and give it the name as an existing note, FSNotes 1.3 displays two notes with the same name. Then, after FSNotes is restarted:

  • The renamed note reverts to its original name.

  • Edits to the renamed note are lost if those edits were made after the note was renamed and without selecting the note's name in the note list.

glushchenko added a commit that referenced this issue Mar 26, 2018
@glushchenko
Copy link
Owner

Please try 1.3.1

@peavine
Copy link
Author

peavine commented Mar 27, 2018

I installed FSNotes 1.3.1 but the issue remains. To duplicate this:

  1. Create two notes named Note 1 and Note 2.

  2. Click on Note 1 in the Notes List.

  3. Use CMD+R to rename Note 1 to Note 2. The Notes List now shows two notes with the name Note 2 and the cursor is in the editor window of what used to be Note 1 (I have enabled the focus-in-editor preference).

  4. Type some text and exit FSNotes

  5. After restarting FSNotes, the note that I renamed to Note 2 in 3 above now has the name Note 1, and the text I typed in 4 above is gone.

Thanks.

@peavine peavine closed this as completed Mar 27, 2018
@peavine peavine reopened this Mar 27, 2018
glushchenko added a commit that referenced this issue Mar 27, 2018
@glushchenko
Copy link
Owner

Fixed in 1.3.2

@peavine
Copy link
Author

peavine commented Mar 27, 2018

I installed FSNotes 1.3.2, and this issue is fixed except under one unlikely circumstance, which is illustrated as follows:

  1. Create three notes with the names Books, Post, and Work.

  2. Attempt to rename the Books note to Work and then the People note to Work. In both instances, a dialog notifies that this action is not allowed, and, as expected, the Notes List shows Books, Post, and Work.

  3. Create a new note. The notes list now shows four notes with the names Untitled Note, Work, Work, and Work.

  4. Restart FSNotes and the notes shown are Books, Post, Untitled Note, and Work.

Thanks for all your hard work on this issue.

glushchenko added a commit that referenced this issue Apr 4, 2018
@glushchenko
Copy link
Owner

Fixed in 1.4

@peavine
Copy link
Author

peavine commented Apr 4, 2018

I installed 1.4 and everything works great. Thanks.

@peavine peavine closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants