-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
currently, kubespray supports kubernetes 1.12.x releases once we get kube 1.13.0 support in kubespray we can merge this PR. |
*CSI is updated to v1.0.0 *removed CRD for driver register and node info Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
|
@JohnStrunk PTAL. dont merge this PR till we support csi 1.0 in gluster-csi-driver |
once we get the container out of gluster/gluster-csi-driver#133 we can merge this one. |
once we merge this one we need to fix #100. but this is not a blocker as antill pod does nothing as of now. |
FYI , The CSI patch has been merged. |
/lgtm. |
@kshlm @JohnStrunk PTAL |
@atinmu @kshlm @aravindavk can we review this PR on priority, current GCS deployment is failing as CSI docker image is updated to CSI 1.0.0 |
Thanks @Madhu-1 . I'm currently doing a deploy with this. Will merge once it finishes successfully. |
@@ -37,6 +37,10 @@ fi | |||
echo "Ensuring kubespray is present" | |||
git submodule --quiet init | |||
git submodule --quiet update | |||
cd kubespray | |||
#check out to support kube 1.13.1 | |||
git checkout 39d750 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required. The git submodule (init|update)
commands above should checkout the correct git hash as you've also committed the submodule git hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kshlm
I have faced the issue if I delete the kubespray dir and rerun the prepare.sh locally so added these lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kshlm @Madhu-1 I this is overriding the submodule commit... I think this needs to be removed.
The submodule commands may also not be what we want... not really sure. We need to make sure that a commit of gcs w/ a particular kubespray hash is sufficient to advance the version w/o updating the hash in the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnStrunk #105 PTAL
Fixes: #101 |
Signed-off-by: Madhu Rajanna mrajanna@redhat.com