Skip to content
This repository has been archived by the owner on May 24, 2020. It is now read-only.

Update kubernetes version to 1.13.1 #77

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Dec 4, 2018

  • CSI is updated to v1.0.0
  • Removed CRD for driver register and node info

Signed-off-by: Madhu Rajanna mrajanna@redhat.com

@Madhu-1 Madhu-1 added the do-not-merge indicates that PR should not be merged label Dec 4, 2018
@ghost ghost assigned Madhu-1 Dec 4, 2018
@ghost ghost added the in progress label Dec 4, 2018
@Madhu-1
Copy link
Member Author

Madhu-1 commented Dec 4, 2018

currently, kubespray supports kubernetes 1.12.x releases

once we get kube 1.13.0 support in kubespray we can merge this PR.

*CSI is updated to v1.0.0
*removed CRD for driver register and node info

Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 5, 2019

[mrajanna@localhost deploy]$ kubegcs get po
NAME                                   READY   STATUS             RESTARTS   AGE
anthill-58b9b9b6f-zfj85                0/1     CrashLoopBackOff   6          12m
csi-attacher-glusterfsplugin-0         2/2     Running            0          4m20s
csi-nodeplugin-glusterfsplugin-572j6   2/2     Running            1          4m20s
csi-nodeplugin-glusterfsplugin-d4fqh   2/2     Running            0          4m20s
csi-nodeplugin-glusterfsplugin-pqm22   2/2     Running            1          4m20s
csi-provisioner-glusterfsplugin-0      3/3     Running            0          4m20s
etcd-2k82znllv9                        1/1     Running            0          9m52s
etcd-6v8lvfdnbh                        1/1     Running            0          12m
etcd-9cxvgm79wv                        1/1     Running            0          10m
etcd-operator-77bfcd6595-6mssd         1/1     Running            0          12m
gluster-kube1-0                        1/1     Running            0          9m42s
gluster-kube2-0                        1/1     Running            1          9m41s
gluster-kube3-0                        1/1     Running            1          9m40s
[mrajanna@localhost deploy]$ kube get pvc
NAME                 STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS    AGE
gcs-example-volume   Bound    pvc-3a7db00e-10ab-11e9-b504-52540001049b   1Gi        RWX            glusterfs-csi   81s
[mrajanna@localhost deploy]$ kube get po
NAME          READY   STATUS    RESTARTS   AGE
gcs-example   1/1     Running   0          87s
[mrajanna@localhost deploy]$ kube version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:39:04Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:31:33Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

@Madhu-1 Madhu-1 removed the do-not-merge indicates that PR should not be merged label Jan 5, 2019
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 5, 2019

@JohnStrunk PTAL. dont merge this PR till we support csi 1.0 in gluster-csi-driver

@Madhu-1 Madhu-1 added the do-not-merge indicates that PR should not be merged label Jan 5, 2019
@Madhu-1 Madhu-1 removed the do-not-merge indicates that PR should not be merged label Jan 5, 2019
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 5, 2019

once we get the container out of gluster/gluster-csi-driver#133 we can merge this one.

@Madhu-1 Madhu-1 requested review from JohnStrunk and kshlm January 5, 2019 05:41
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 5, 2019

once we merge this one we need to fix #100. but this is not a blocker as antill pod does nothing as of now.

@humblec
Copy link

humblec commented Jan 6, 2019

FYI , The CSI patch has been merged.

@humblec
Copy link

humblec commented Jan 6, 2019

/lgtm.

@Madhu-1 Madhu-1 changed the title Update kubernetes version to 1.13.0 Update kubernetes version to 1.13.1 Jan 7, 2019
@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 7, 2019

@kshlm @JohnStrunk PTAL

@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 7, 2019

@atinmu @kshlm @aravindavk can we review this PR on priority, current GCS deployment is failing as CSI docker image is updated to CSI 1.0.0

@kshlm
Copy link
Member

kshlm commented Jan 7, 2019

Thanks @Madhu-1 . I'm currently doing a deploy with this. Will merge once it finishes successfully.

@@ -37,6 +37,10 @@ fi
echo "Ensuring kubespray is present"
git submodule --quiet init
git submodule --quiet update
cd kubespray
#check out to support kube 1.13.1
git checkout 39d750
Copy link
Member

@kshlm kshlm Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required. The git submodule (init|update) commands above should checkout the correct git hash as you've also committed the submodule git hash.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kshlm
I have faced the issue if I delete the kubespray dir and rerun the prepare.sh locally so added these lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kshlm @Madhu-1 I this is overriding the submodule commit... I think this needs to be removed.
The submodule commands may also not be what we want... not really sure. We need to make sure that a commit of gcs w/ a particular kubespray hash is sufficient to advance the version w/o updating the hash in the script.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 7, 2019

Fixes: #101

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants