-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail if the cachedisk does not exist #50
base: master
Are you sure you want to change the base?
Conversation
@@ -6,6 +6,14 @@ | |||
# Extend the existing volume group with the SSD (assuming SSD is used for | |||
# caching) | |||
|
|||
# Fail if the cache disk is not present | |||
- name: Check if the cachedisk exists, else fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move all such validations to a pre-checks dir? And execute the pre-checks in the main.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that, is there a possibility that RHHI would be installed without cache? If so we have to maintain the cachedisk check separate and call only when user calls for setting up cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible as cache setup is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible as cache setup is optional
@sabose I'm sorry I missed this. So, if cache is optional, we need not move it to main.yml and call this every time irrespective of whether user wants to setup cache or not. Over here it gets validated only if user tries to setup cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move validations to a pre-checks folder?
@sabose I have answered this in the above comment: | Yes, it's possible as cache setup is optional @sabose I'm sorry I missed this. So, if cache is optional, we need not move it to main.yml and call this every time irrespective of whether user wants to setup cache or not. Over here it gets validated only if user tries to setup cache. |
No description provided.