systemd: clear the target config only when tcmu-runner is running #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pkalever
force-pushed
the
systemd_target_clear
branch
from
fd85c5d to
f708031
Compare
|
On Mon, Oct 15, 2018 at 07:19:25AM -0700, Prasanna Kumar Kalever wrote:
@nixpanic
Requirement is we need to run targetctl clear only when tcmu-runner is running. I need your opinion at this changes. Do you foresee any issues with this hack ? Thanks!
As briefly discussed and further explained on IRC, it looks good to me.
|
pkalever
force-pushed
the
systemd_target_clear
branch
from
f708031 to
615a5cb
Compare
Yeah, Prasanna, this works for me. |
lxbsz
approved these changes
Oct 16, 2018
Tested-by: Xiubo Li <xiubli@redhat.com> Reviewed-by: Xiubo Li <xiubli@redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
force-pushed
the
systemd_target_clear
branch
from
615a5cb to
6010219
Compare
|
Thanks @lxbsz for the review and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com