Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USER field available in Block Info. #21

Closed
wants to merge 1 commit into from

Conversation

humblec
Copy link

@humblec humblec commented May 12, 2017

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@pkalever
Copy link
Contributor

It was an intentional :-)
The GBID is username in "gluster-block info" response.
so we don't want to duplicate GBID and USERNAME.

Thanks for the effort though.

@humblec
Copy link
Author

humblec commented May 12, 2017

@pkalever Auth enable reflect a new USERNAME field, why its so then? Also, how come one can assume "GBID" is the USERNAME from just looking at the info response?

@pkalever
Copy link
Contributor

pkalever commented May 12, 2017

I personally don't like to see duplicated fields in the info.
May be we can do below,

  1. document GBID uses like filename, username, wwid, iqn postfix ...
  2. when auth is enable s/GBID/USERNAME/
  3. In the worst case, we can print like "GBID/USERNAME: bla bla bla bla"

the order is w.r.t my choice, point 1 is most preferable.

@vbellur @pranithk Thoughts ?

@humblec
Copy link
Author

humblec commented May 12, 2017

@pkalever I can adjust the patch to 2 or 3. I think making USERNAME visible is valid in the outputs. 4th choice would be removing password from the info. Will wait for others opinion as well, before sending next version.

@humblec
Copy link
Author

humblec commented May 15, 2017

@vbellur any thoughts here? :)

@pranithk
Copy link
Member

3rd option looks good to me.

@vbellur
Copy link
Member

vbellur commented May 24, 2017

3rd option looks good to me too, thanks!

@pkalever
Copy link
Contributor

@humblec Please make the changes to reflect 3rd option and submit to our gerrit repository, as we are not ready for github yet.

The Current repository that we are using is gerrit, merging your changes with github will reflect into origin and these are all together different repos.

@pkalever
Copy link
Contributor

pkalever commented Jun 6, 2017

@humblec do you have plans to work on this soon ?

@pkalever
Copy link
Contributor

pkalever commented Jun 5, 2018

Please reopen this, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants