golint warnings shouldn't be ignored

[kshlm]

make verify currently runs golint as a part of gometalinter which is configured to mask warnings.
This has created a lot of code which doesn't follow the suggested Go coding style. This needs to be fixed.

[prashanthpai]

I'm fixing most of it right now. Will send a PR soon.

[kshlm]

@prashanthpai All of them? Or just for your PR? If it's all of them, awesome job!

[kshlm]

Also make verify needs to be updated to not mask golint. It would be better to have separate golint run outside of gometalinter.

[prashanthpai]

@kshlm Most of them, yes, except few places (transaction package) where it's generated code and adding //golint:ignore line into them did not seem to work for me.

Check out #157

[prashanthpai]

@kshlm For some reason, make verify gets stuck on my system for a very long time. Running gometalinter directly doesn't run most of the other checks.

[ppai@gd2-1 glusterd2]$ gometalinter 
main.go:19::warning: cyclomatic complexity 11 of function main() is high (> 10) (gocyclo)
config.go:15:2:warning: const defaultRpcAddress should be defaultRPCAddress (golint)
config.go:16:2:warning: const defaultRpcPort should be defaultRPCPort (golint)
main.go:64:5:warning: should omit comparison to bool constant, can be simplified to !gdctx.Restart (gosimple)
config.go:46::warning: Errors unhandled.,LOW,HIGH (gas)
WARNING: deadline exceeded by linter aligncheck on . (try increasing --deadline)
WARNING: deadline exceeded by linter varcheck on . (try increasing --deadline)
WARNING: deadline exceeded by linter interfacer on . (try increasing --deadline)
WARNING: deadline exceeded by linter unconvert on . (try increasing --deadline)
WARNING: deadline exceeded by linter structcheck on . (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck on . (try increasing --deadline)

[kshlm]

For the problem with golint, check this kshlm@daec652

I'd begun working on this a little while ago. I stopped because I didn't want fix all the lint warning at the time.

[kshlm]

@kshlm For some reason, make verify gets stuck on my system for a very long time. Running gometalinter directly doesn't run most of the other checks.

Most of the checkers got killed by the deadline. It's too short. I set the deadline to 5 minutes to have all checkers run.

[prashanthpai]

For the problem with golint, check this kshlm/glusterd2@daec652

There's also golang/lint#249 and golang/lint#239