This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Fix golint warnings #157
Merged
Fix golint warnings #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You probably want to make sure that all code adheres to |
|
@purpleidea, we're using gometalinter, which runs a bunch of stuff, including golint and go vet. |
2 similar comments
|
@purpleidea, we're using gometalinter, which runs a bunch of stuff, including golint and go vet. |
|
@purpleidea, we're using gometalinter, which runs a bunch of stuff, including golint and go vet. |
Barring transaction subpackage which contains mainly generated code, other subpackages have had their golint warnings fixed. We would want to ensure that all new code adheres to golint. Signed-off-by: Prashanth Pai <ppai@redhat.com>
prashanthpai
force-pushed
the
golint-fixes
branch
from
259c841 to
f92dde5
Compare
|
@kshlm Rebased to master. Consider merging this. |
kshlm
approved these changes
Nov 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barring transaction subpackage which contains mainly generated code,
other subpackages have had their golint warnings fixed.
We would want to ensure that all new code adheres to golint.
Signed-off-by: Prashanth Pai ppai@redhat.com