Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added upgrade guide for release-8 #565

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Added upgrade guide for release-8 #565

merged 1 commit into from
Jun 22, 2020

Conversation

rkothiya
Copy link

Signed-off-by: Rinku Kothiya rkothiya@redhat.com

harigowtham
harigowtham suggested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@harigowtham harigowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were things which were missed to be updated in the past. I think its better to get them fixed. So it will reduce the incoming issues with upgrade for us. I have pointed out such changes. Do let me kow you thoughts

docs/Upgrade-Guide/upgrade_to_8.md Outdated Show resolved Hide resolved
docs/Upgrade-Guide/upgrade_to_8.md Show resolved Hide resolved
docs/Upgrade-Guide/upgrade_to_8.md Show resolved Hide resolved
harigowtham
harigowtham suggested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@harigowtham harigowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do verify the other reference to upgrading from 3.12 are removed.

docs/Upgrade-Guide/upgrade_to_8.md

2. Make sure you are not using any of the following depricated features :

- Block device (bd) xlator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These options can be merged with the above options mentioned as deprecated in line 16.

docs/Upgrade-Guide/upgrade_to_8.md

To check if these options are set use,

```console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps mentioned here and in the link provided below is a little confusing.

docs/Upgrade-Guide/README.md Outdated
@@ -4,6 +4,7 @@ Upgrading GlusterFS

If you are using GlusterFS version 3.10.x or above, you can upgrade it to the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove reference to 3.x here and in the other places of this file as well.

@harigowtham
Copy link
Member

As per the discussion we decided to handle the reference to ./upgrade_to_4.1.md being changed as per the release-8 in a separate patch. The other issue is tracked along with #566.
The upgrade guide has to be containing enough info as in the link of the upgrade to 4.1 guide (with necessary details) This will help with providing a clear picture on how to upgrade.
Having multiple redirects might end up confusing users.

Added upgrade guide for release-8
2eb234b 
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
@rkothiya rkothiya merged commit cfde275 into gluster:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harigowtham harigowtham harigowtham requested changes

@kshithijiyer kshithijiyer kshithijiyer approved these changes

@ShyamsundarR ShyamsundarR Awaiting requested review from ShyamsundarR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkothiya @harigowtham @kshithijiyer