New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-411: Stop using rustc nightly version #898

Draft

atodorov wants to merge 1 commit into dev from CSUB-411-use-stable-rustc

Contributor

atodorov commented Jan 30, 2023

Description of proposed changes:

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

Contributor Author

atodorov commented Feb 9, 2023

https://github.com/paritytech/substrate/tree/polkadot-v0.9.32/utils/wasm-builder#prerequisites needs rustc nightly.


          Stop using rustc nightly version

2638fc3

atodorov force-pushed the CSUB-411-use-stable-rustc branch from 35596ee to 2638fc3 Compare

March 16, 2023 12:20

Contributor Author

atodorov commented Apr 17, 2023

Will be available in polkadot-v0.9.42

atodorov mentioned this pull request

build(deps): bump chevdor/srtool-actions from 0.6.0 to 0.7.0 #1042

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet