Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade cc3 node to latest frontier, polkadot sdk + todo #470

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

rustlang-dev
Copy link
Contributor

Description of proposed changes

upgrade cc3 node to latest frontier, polkadot sdk but still some todo


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@rustlang-dev rustlang-dev requested a review from a team as a code owner September 13, 2024 14:56
@rustlang-dev rustlang-dev requested review from jonZlotnik and dlebee and removed request for a team, jonZlotnik and dlebee September 13, 2024 14:56
@rustlang-dev rustlang-dev merged commit 9703f74 into fix-overrides-evm-cache-task Sep 13, 2024
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant