Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cc3 forks fix ci after updating fork of frontier and polkadot sdk #497

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: cc3 forks fix ci after updating fork of frontier and polkadot sdk #497

merged 3 commits into from
Sep 23, 2024

Conversation

rustlang-dev
Copy link
Contributor

Description of proposed changes

fix: cc3 forks fix ci after updating fork of frontier and polkadot sdk

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@rustlang-dev rustlang-dev requested a review from a team as a code owner September 23, 2024 21:54
@rustlang-dev rustlang-dev requested review from mostafaesmaeilli and wahid-gluwa and removed request for a team September 23, 2024 21:54
@rustlang-dev rustlang-dev merged commit 281bb2d into handle-polkadot-forks Sep 23, 2024
13 of 14 checks passed
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafaesmaeilli mostafaesmaeilli Awaiting requested review from mostafaesmaeilli mostafaesmaeilli was automatically assigned from gluwa/protocol

@wahid-gluwa wahid-gluwa Awaiting requested review from wahid-gluwa wahid-gluwa was automatically assigned from gluwa/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rustlang-dev