Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check migration locally. new runtime on top of old node + runtime #500

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

rustlang-dev
Copy link
Contributor

Description of proposed changes

check migration locally. new runtime on top of old node + runtime


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@rustlang-dev rustlang-dev requested a review from a team as a code owner September 25, 2024 19:27
@rustlang-dev rustlang-dev requested review from atodorov and jonZlotnik and removed request for a team September 25, 2024 19:27
@rustlang-dev rustlang-dev marked this pull request as draft September 25, 2024 19:28
Copy link

For full LLVM coverage report click here!

@rustlang-dev rustlang-dev marked this pull request as ready for review September 27, 2024 20:56
@rustlang-dev rustlang-dev merged commit 3fdc7ae into handle-polkadot-forks Sep 27, 2024
36 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant