Skip to content

Commit

Permalink
Always run file.managed on x509 certificates
Browse files Browse the repository at this point in the history
This ensures that the certificate file has the intended file
properties, even if the certificate contents themselves don't need to change.

See saltstack#52935 (comment)
  • Loading branch information
glynnforrest committed May 23, 2020
1 parent 90a36b4 commit f67f5f8
Showing 1 changed file with 23 additions and 8 deletions.
31 changes: 23 additions & 8 deletions salt/states/x509.py
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,25 @@ def _certificate_is_valid(name, days_remaining, append_certs, **cert_spec):
return False, "{0} is not a valid certificate: {1}".format(name, str(e)), {}


def _certificate_file_managed(ret, file_args):
"""
Run file.managed and merge the result with an existing return dict.
The overall True/False result will be the result of the file.managed call.
"""
file_ret = __states__["file.managed"](**file_args)

ret["result"] = file_ret["result"]
if ret["result"]:
ret["comment"] = "Certificate {0} is valid and up to date".format(ret["name"])
else:
ret["comment"] = file_ret["comment"]

if file_ret["changes"]:
ret["changes"] = {"File": file_ret["changes"]}

return ret


def certificate_managed(
name, days_remaining=90, append_certs=None, managed_private_key=None, **kwargs
):
Expand Down Expand Up @@ -619,9 +638,9 @@ def certificate_managed(
)

if is_valid:
ret["result"] = True
ret["comment"] = "Certificate {0} is valid and up to date".format(name)
return ret
file_args, extra_args = _get_file_args(name, **kwargs)

return _certificate_file_managed(ret, file_args)

if __opts__["test"]:
ret["result"] = None
Expand Down Expand Up @@ -664,10 +683,8 @@ def certificate_managed(

file_args, extra_args = _get_file_args(name, **kwargs)
file_args["contents"] = contents
file_ret = __states__["file.managed"](**file_args)

if file_ret["changes"]:
ret["changes"] = {"File": file_ret["changes"]}
ret = _certificate_file_managed(ret, file_args)

ret["changes"]["Certificate"] = {
"Old": current_cert_info,
Expand All @@ -677,8 +694,6 @@ def certificate_managed(
"Old": invalid_reason,
"New": "Certificate is valid and up to date",
}
ret["comment"] = "Certificate {0} is valid and up to date".format(name)
ret["result"] = True

return ret

Expand Down

0 comments on commit f67f5f8

Please sign in to comment.