feat: add border radius option for bar components #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-berger
changed the title
|
Couldn't figure this one out for myself, so thanks for solving this 🙏 Re. the 1px transparent border, I don't why that's popping up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There are two parts this pull request:
If you want me to split these to 2 different PRs let me know.
The changes to the bar fix the background overflowing the border. Here is the before and after:
I have also added the possibility of adding rounded corners to bar components. With this I have a small problem. For some components there is a 1 pixel line that is transparent for some reason:
If you have any ideas how to fix that or any other recommendations let me know.
Joonatan