Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added music status component #473

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

AleGrz
Copy link
Contributor

@AleGrz AleGrz commented Dec 14, 2023

Added a fully configurable component that can display currently playing music and artist name. I closed #466 and squashed the branch, so now it should pass the checks. I'm still learning how to use git, sorry about that.

@Video-Nomad
Copy link
Contributor

Video-Nomad commented Dec 16, 2023

Tried this and it works great!
Some observations:

  • While Spotify and other dedicated music apps update the play status instantly, chrome/edge/etc. does not. Not sure why, but it takes a while to switch from "paused" to "playing". Seems like a Windows thing, not the component itself. This behavior is not consistent, as sometimes it updates instantly... Update: seems like it was an issue on my end.
  • The label is not truncated. It would have been great to have a "max length" option to truncate it, similarly how window title component is truncated now (but not hardcoded). The label gets pretty long when you play a youtube video.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AleGrz
Copy link
Contributor Author

AleGrz commented Dec 18, 2023

I added trimming to title and artist individually, I think it looks better than truncating the whole label at once

@lars-berger
Copy link
Member

Wow, this looks great @AleGrz 🙌 The code is excellent and it's working without issue on my end. Will go ahead and merge

@lars-berger lars-berger merged commit 537edda into glzr-io:develop Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants