feat: add command set-tiling-direction [vertical|horizontal]
#702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-berger
requested changes
Aug 31, 2024
|
Thanks for the pr 🙌 was looking to get this added at some point Added some minor fixups otherwise lgtm |
|
Thank you for the feedback. I have adjusted the code accordingly. |
JonasWischeropp
changed the title
set-tiling-direction-vertical and set-tiling-direction-horizontalset-tiling-direction [vertical|horizontal]
|
Awesome, thank you ❤️ |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the two commands
set-tiling-direction-verticalandset-tiling-direction-horizontalin order to be able to set the tiling direction faster and in the same way it is done in
i3wm.When using
toggle-tiling-directionone always has to identify the current direction first.Let me know what you think. Specially whether using
panic!here is the right method:https://github.com/JonasWischeropp/glazewm/blob/3c3fd07cd667c7e6165aa422d144e88ee0858af0/packages/wm/src/containers/commands/toggle_tiling_direction.rs#L110
Thank you for this amazing window manager.