refactor: clippy fixes and working doctests #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miitto
force-pushed
the
feat-lint-fixes
branch
from
690c1b4 to
4897fe3
Compare
lars-berger
reviewed
Nov 5, 2024
packages/wm/src/containers/commands/flatten_child_split_containers.rs
Outdated
Show resolved
Hide resolved
lars-berger
changed the title
|
This is super nice!! Been meaning to add clippy linting for ages 🙌 Would you happen to know what the recommended command would be to to add linting to CI? |
|
Not sure how to add it to CI, but it can be manually run via Can be added to the tool chain via on: push
name: Clippy check
# Make sure CI fails on all warnings, including Clippy lints
env:
RUSTFLAGS: "-Dwarnings"
jobs:
clippy_check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run Clippy
run: cargo clippy --all-targets --all-features
Example taken from here |
|
Merged 👍 Will look into getting rid of those unused var warnings - would be super nice to enforce these lints for PR's. Ty for the info on adding it to CI! |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting
Fixes most lint errors provided by clippy
Unused variables / functions have not been fixed
Clippy detects
needless_returnon bothmainfunctions, which I believe is caused by#[tokio::main], so these have been supressed.Doctests
The following are no longer run:
wm\src\containers\commands\flatten_child_split_containers.rs:11:flatten_child_split_containershas been ignoredwm\src\common\platform\platform.rs:340:parse_commandhas been set tono_runas it requires files to exist on the test machine.The following have been fixed so that they can be compiled and ran:
wm\src\common\tiling_direction.rs:19:inversewm\src\common\tiling_direction.rs:35:from_directionwm\src\common\tiling_direction.rs:54:from_strwm\src\common\direction.rs:19:inversewm\src\common\direction.rs:40:from_strwm\src\common\length_value.rs:52:from_str