fix: regression in layouting with fullscreen state #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have been doing some testing, and I believe this issue is resolved now with #851 (while still preserving the functionality of fullscreen'ing to the full monitor size). There's still good ideas here - as discussed on Discord, it'd be a nice addition to draw inspo from this PR and have some way of conditionally fullscreen'ing to either the full monitor size or the working area (e.g. via a new flag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression in layouting with fullscreen state
This PR fixes an issue where window's fullscreen state would overflow under existing elements in the desktop. Currently GlazeWM doesn't take in-account the delta offsets of the working area of the monitor when calculating fullscreen state window size, thus graphical issues occur in the latest version of GlazeWM. This PR should fix it.
Note: This PR works best with #836 PR, since it also fixes issues with graphical issues, related to the delta offsets of working area.
Before:
explorer_ZxGbJ83uFL.mp4
After:
explorer_l0NFjZg4yo.mp4