fix: float windows by default if they have WS_POPUP style
#941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up to be floating instead of tiled.
lars-berger
requested changes
Jan 26, 2025
|
Good point! Think this would make a lot of sense to add as a default 👌 Thank you for the PR |
ChichiMsdk
commented
Jan 26, 2025
lars-berger
approved these changes
Jan 29, 2025
lars-berger
changed the title
WS_POPUP style
|
Awesome 🙏 Made a quick linting fix (hope it's ok I pushed directly to the branch). I held off including this in the current release to give some more time for testing with different apps. From what I've seen in some quick initial testing though, it's looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to set windows meant to have a specific size (but they are still resizable) to be in floating mode instead of tiling by default.
This could maybe replace the workarounds using the window class for some explorer's popups. Would have to check if those windows have the 'WS_POPUP' flag or not.
Without this, many windows are improperly resized and makes the tiling manager almost unusable, especially with softwares like Visual Studio or Ghidra.