You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @gmarm,
First thing, thanks for building this library, it's great and exactly what I was needed!
I'd like to suggest few things to change, to make the library even better:
Make settings options more easier to understand
In the beginning I thought there is no way to change it, but now I find out that I can change it via options property, it's not the most understandable way and I couldn't find any examples in the README.md or in the Example project, I think you should do something about it.
Remove layer.masksToBounds = true from line 310 when indicatorViewInset is negative
When the indicatorViewInset is negative you should get nice effect like this:
But instead of that the indicatorViewBackground is cutting of when it's passing the BetterSegmentedControl parent view because of this line.
I don't see any problem after comment it out so it's just unnecessary.
Hi @gmarm,
First thing, thanks for building this library, it's great and exactly what I was needed!
I'd like to suggest few things to change, to make the library even better:
Make settings
options
more easier to understandIn the beginning I thought there is no way to change it, but now I find out that I can change it via
options
property, it's not the most understandable way and I couldn't find any examples in theREADME.md
or in the Example project, I think you should do something about it.Remove
layer.masksToBounds = true
from line 310 whenindicatorViewInset
is negativeWhen the
indicatorViewInset
is negative you should get nice effect like this:But instead of that the
indicatorViewBackground
is cutting of when it's passing theBetterSegmentedControl
parent view because of this line.I don't see any problem after comment it out so it's just unnecessary.
I'v created pull request for this: #87
Thanks,
Ido.
The text was updated successfully, but these errors were encountered: