We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--files-from
Currently the file list supplied via --files-from is split at each line feed \n:
\n
xgettext/index.js
Lines 195 to 201 in 2a23cf5
This leads to problems with lists generated by programs that produce "Windows linebreaks" (CR LF, \r\n).
\r\n
This is why I suggest changing the current behaviour and making line splitting work like in GNU gettext: https://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/src/file-list.c?id=b26729c67cffb2403d8a20b44606f5a08cb901b5#n68
What is done is basically this:
\t
\r
The text was updated successfully, but these errors were encountered:
This sounds really good! Thank you for the research!
Would you be able to send a PR? In that case please also extend the current --files-from test in test/cli.js to include at least 2 lines.
test/cli.js
Sorry, something went wrong.
I'll send a PR as soon as I get a bit of free time.
Make --files-from work like in gettext
323abca
Fixes gmarty#74
No branches or pull requests
Currently the file list supplied via
--files-from
is split at each line feed\n
:xgettext/index.js
Lines 195 to 201 in 2a23cf5
This leads to problems with lists generated by programs that produce "Windows linebreaks" (CR LF,
\r\n
).This is why I suggest changing the current behaviour and making line splitting work like in GNU gettext: https://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/src/file-list.c?id=b26729c67cffb2403d8a20b44606f5a08cb901b5#n68
What is done is basically this:
\n
\t
, space (I'm not sure this is actually a good idea) and\r
from the end of the string.The text was updated successfully, but these errors were encountered: