Skip to content

Commit

Permalink
Clarify CompareGuid change
Browse files Browse the repository at this point in the history
* Update guid.c to display correct output code in description
* Add warning about failure in ABI README

Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
  • Loading branch information
gmbr3 committed Sep 23, 2024
1 parent adfac3f commit 7665a48
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions docs/README.ABI.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,12 @@ versions

This currently includes the following functions:
- ReallocatePool

- CopyMem

- CompareGuid

**Will break at runtime - likely causing opposite output to expected**

2) Applications which haven't been updated in a while may also be missing the
required `.rodata` section which contains needed read-only data which will prevent
Expand Down
2 changes: 1 addition & 1 deletion lib/guid.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ Routine Description:
Guid2 - guid to compare
Returns:
= 0 if Guid1 == Guid2
= 1 if Guid1 == Guid2
--*/
{
Expand Down

0 comments on commit 7665a48

Please sign in to comment.