Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical: subtitle builder is broken #27

Closed
gmertes opened this issue Jun 16, 2022 · 2 comments · Fixed by #28
Closed

Critical: subtitle builder is broken #27

gmertes opened this issue Jun 16, 2022 · 2 comments · Fixed by #28
Labels
bug Something isn't working

Comments

@gmertes
Copy link
Owner

gmertes commented Jun 16, 2022

Netflix changed something in the subtitle manifest, breaking the subtitle builder in the SubtitleFactory class. Bug is located around the ttDownloadables field and targetProfile key here, triggering the error catch below it.

This is a critical breaking bug, will investigate ASAP but may not have time until the weekend. If anyone already has a fix ready, PR is welcome.

Thanks to @lampy9 for the report! ( it is unrelated to the Safari issue :) )

@gmertes gmertes added the bug Something isn't working label Jun 16, 2022
@gmertes
Copy link
Owner Author

gmertes commented Jun 18, 2022

@WingCH Also pinging you here: bug has been fixed in latest commit, you could update the Safari version 🤗 You do need to check if this commit is compatible cause it introduces a new option field for the text colour, but if you use the kDefaultSettings object to populate the options it should be compatible. I bumped the minor version cause I haven't really been paying attention to semver, technically I think the text colour setting classifies as new functionality😅

@WingCH
Copy link

WingCH commented Jun 19, 2022

@gmertes Thanks for your notice, I just uploaded a new version to apple, this version only contains bug fixes, not updates about the settings page.
The current safari version hides the settings page, because safari is not compatible with chrome.runtime postMessage, I tried to simply use browser.runtime , but it seems have other problems, the settings page does not work properly, safari is not like chrome and firefox like easy to debug😵, I need extra timeto develop these features for safari, so I choose to hide the settings page, I know this is not the solution, I will study it in my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants