Fix: secondary subtitles not showing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! I'll submit a new version with this fix today. Those new extra subtitles are indeed quite interesting. I think I'll open a new issue to address this, would be nice if we can also find a way to use them as secondary subs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix #27
Filter out null SubtitleFactory.build result allows the secondary subtitles menu being showed correctly, this is a partial fix beacuse netflix added some extra subtitles in which the subtitle manifest seem to have missing fields, ttDownloadables for those extra subtitles is empty, generating the bug in nflxmultisubs.js#L456.
This pr aims to solve the problem for the previous existing subtitles, the new extra subtitles could require some new way to build them or just wait for netflix to update the manifest to correspond with the previous existing subtitles