Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
company
was previously required to handle the limitation of gathering completions from multiple backends/functions withcompletion-at-point
:comint
is to setcompletion-at-point-functions
tocomint-dynamic-complete-functions
comint-dynamic-complete-functions
has the default value'(comint-c-a-p-replace-by-expanded-history comint-filename-completion)
. These functions work as if they werecompletion-at-point-functions
themselves, returning completions if found and returning nil and checking next function if not. The recommended approach is to add a new capf function tocomint-dynamic-complete-functions
.comint-filename-completion
fpga-*-capf
is not called since previous one was already successfulThe PR implements a single capf function that handles both files and commands.
It also adds a customizable variable:
fpga-utils-shell-file-completion
, if file completion inside capf is not desired. This could be the case if usingcompany-files
backend with the following snippet: