No build is faster than any build #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://gustavocunha-staging-pr-1086.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ckhdff8mccbs73etknl0. |
gmmcal
force-pushed
the
actions
branch
25 times, most recently
from
8a12d40 to
d518b67
Compare
gmmcal
force-pushed
the
actions
branch
4 times, most recently
from
bc3cb75 to
fb2f922
Compare
gmmcal
force-pushed
the
actions
branch
21 times, most recently
from
82478dd to
58c592a
Compare
* Dockerize application * Replace SASS with pure CSS * Remove JS via node and replace with importmap * Run Tests and Lint on docker image built from application, making errors more reproducible (if they happen) * Fix UI issues on admin modal * Upgrade simple-form to boostrap 5 * WIP docker image for Cypress tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to restructure the entire application to accomplish a faster boot time, easier to code/maintain, with less dependencies (specially node ones).
After all those changes, the app is now faster to boot and much simpler to maintain. There is still a lot to do, specially reducing/removing tailwind compiled CSS and bootstrap CSS on admin.
After all CSS is rewritten, I can get rid of SCSS folder, SCSSLint and (potentially) some other things, making setup even simpler.
Motivation and Context
I was triggered by DHH keynote on Rails World (the title is a quote from talk). After a lot of experimentation, I was able to:
Along with those changes, there are some other improvements:
How Has This Been Tested?
Types of changes
Checklist: