cleaned up naming

gmmorris · Jan 2, 2020 · d1ef6ef · d1ef6ef
1 parent 6223180
commit d1ef6ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/x-pack/test/alerting_api_integration/common/lib/alert_utils.ts b/x-pack/test/alerting_api_integration/common/lib/alert_utils.ts
@@ -17,7 +17,7 @@ export interface AlertUtilsOpts {
   objectRemover?: ObjectRemover;
 }
 
-export interface CreateAlwaysFiringActionOpts {
+export interface CreateAlertWithActionOpts {
   indexRecordActionId?: string;
   objectRemover?: ObjectRemover;
   overwrites?: Record<string, any>;
@@ -159,7 +159,7 @@ export class AlertUtils {
     overwrites = {},
     indexRecordActionId,
     reference,
-  }: CreateAlwaysFiringActionOpts) {
+  }: CreateAlertWithActionOpts) {
     const objRemover = objectRemover || this.objectRemover;
     const actionId = indexRecordActionId || this.indexRecordActionId;
 
@@ -213,7 +213,7 @@ export class AlertUtils {
     overwrites = {},
     indexRecordActionId,
     reference,
-  }: CreateAlwaysFiringActionOpts) {
+  }: CreateAlertWithActionOpts) {
     const objRemover = objectRemover || this.objectRemover;
     const actionId = indexRecordActionId || this.indexRecordActionId;
 

diff --git a/x-pack/test/alerting_api_integration/common/lib/test_assertions.ts b/x-pack/test/alerting_api_integration/common/lib/test_assertions.ts
@@ -7,11 +7,11 @@
 import expect from '@kbn/expect';
 
 export function ensureDatetimeIsWithinRange(
-  scheduledRunTime: number,
+  date: number,
   expectedDiff: number,
   buffer: number = 10000
 ) {
-  const diff = scheduledRunTime - Date.now();
+  const diff = date - Date.now();
   expect(diff).to.be.greaterThan(expectedDiff - buffer);
   expect(diff).to.be.lessThan(expectedDiff + buffer);
 }