Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduled updates won't trigger on activation. #136

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

gmodena
Copy link
Owner

@gmodena gmodena commented Jan 12, 2025

Discussed in #125

  • Refactors the update logic so that when a user enables update.auto, updates will no longer be triggered on activation. To achieve this, a distinct systemd unit (flatpak-managed-install-timer) will be enabled when auto updates are turned on. This unit will be executed exclusively by a timer, and will run a variant of the installer script using the --or-update flatpak flag. This approach paves the way for further specialization of onActivation and scheduled execution profiles.

  • Refactors the installer api and script generation into dedicated modules, and introduces unit tests for the code paths that have been modified.

* Refactors the update logic so that when a user enables
`update.auto`, updates will no longer be triggered on activation.

To achieve this, a distinct systemd unit (`flatpak-managed-install-timer`)
will be enabled when auto updates are turned on.

This unit will be executed exclusively by a timer,
and will run a variant of the installer script using the `--or-update`
flatpak flag.

This approach paves the way for further specialization of
onActivation and scheduled execution profiles.

* Refactors the installer api and script generation
into dedicated modules, and introduces unit tests for the
code paths that have been modified.
modules/flatpak/install.nix Outdated Show resolved Hide resolved
@gmodena
Copy link
Owner Author

gmodena commented Jan 15, 2025

I've been daily driving this branch and changes seem stable. Merging.
I'll fix forward in case new issues pop up in main.

@gmodena gmodena merged commit 535af63 into main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant