Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal must be false check to support RabbitMQ Tracing #50

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

hari01584
Copy link
Contributor

RabbitMQ has this special queue called amq.rabbitmq.trace which has these parameters: auto_delete=False, type=ExchangeType.TOPIC, durable=True, internal=True

However initializing internal to False, was throwing error, removing the check, the tracing is working as expected

`

RabbitMQ has this special queue called `amq.rabbitmq.trace` which has these parameters: `auto_delete=False, type=ExchangeType.TOPIC, durable=True, internal=True`

However initializing internal to False, was throwing error, removing the check, the tracing is working as expected

`
@Lancetnik
Copy link

@gmr can you merge this PR, please? Looks like it is unneccessary limitation
Also as the #49 too

@gmr gmr merged commit 89da27c into gmr:main Jan 12, 2024
gmr added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants