Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the call to isAlive() which is broken #1

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Remove the call to isAlive() which is broken #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6335017
Remove the call to isAlive() which is broken
pshved Nov 4, 2022
706ea91
Add check for error condition
pshved Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/xspublic/xscommon/threading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,21 @@ void StandardThread::stopThread(void) noexcept
// return;
// }
//#else
while (isAlive())
xsYield();
int rv = 0;
while (true) {
rv = pthread_tryjoin_np(m_thread, NULL);
if (rv == 0) {
break;
}
if (errno == EBUSY) {
xsYield();
} else {
// Some other error--maybe the thread is invalid?
break;
}
}
//#endif
if (pthread_join(m_thread, NULL))
if (rv != 0)
{
switch (errno)
{
Expand Down