explain in the README differences to lwilletts/mpvc

[m040601]

Hi, first of all thank you for your work and ongoing commitment to this very interesting tool.
I'm trying to figure out if I should use it, in Archlinux, instead of "lwillets/mpvc".
It seems to be more polished, maintained, adding extra functionality. But I'm not 100% sure of your future plans.

I found your repo through https://github.com/stax76/awesome-mpv.
Dont know why it is called "mpv-tui" there. Just confusing.

I'm on Archlinux, and we do have a PKGBUILD for "mpvc" . But it is currently pulling from "lwilletts/mpvc". Not your "gmt4/mpvc"

But because you also copied the README when you forked "lwillets/mpvc", you now have on your own "gmt4/mpvc" README,

If you have packaged mpvc for your distribution, let me know so I can add it here.

Distribution Packages:

    Arch - pacaur -y mpvc-git
    Gentoo - emerge mpvc
    Nixos - nix-env -i mpvc

And it is linking to, https://aur.archlinux.org/packages/mpvc-git . Which pulls from "lwilletts/mpvc". Not your "gmt4/mpvc"

So, because I was considering if the Archlinux PKGBUILD should switch to use yours instead of lwillets, I need more information.

Could you add one or two lines to the README explaining:

• Why did you fork it ?
• Main differences ?
• Do you plan on maintaining this long term ?
• etc ...

Of course everyone can diff download and compare your fork and the original repo to see the differences. But is much nicer if you just this briefly in the README.

Just a suggestion.Maybe if you plan to keep this long term, you should consider renaming it ? Choose your own distinct name ? Just in case lwillets starts updating theirs again ? Or maybe he closes his and contributes to this one ?

Thanks in advance.

[gmt4]

I've tried to answer some of the questions above in the docs & wiki:

• https://gmt4.github.io/mpvc/
• https://github.com/gmt4/mpvc/wiki

Regarding the rest of questions, the nature of the fork is personal need for a working mpvc with the functionality described above. The name mpvc-tui is just the name of one of the disctintive tools found under the extras/ directory. As this is a personal project, the long term view of this repo is limited my own personal use. Anyway I've been maintaining this fork for a year, and It suits my needs, so I plan to keep using and maintaining this in the long term.

Would adding a link to the above pages from at top of the README clarify the fork status?

[gmt4]

@m040601 Report back if the changes are ok, So I can close the issue. Thanks!

[m040601]

Yes, thanks, the changes are OK. Issue can be closed.

The needed information is there now. So package maintainers can decide better which version or fork to use, since you choose to keep the same name "mpvc".

[gmt4]

Thanks, closing the issue.

[gmt4]

If interested here's the latest version bump v1.4: https://github.com/lwilletts/mpvc/releases/tag/1.4

[gmt4]

Changes have been merged to https://github.com/lwilletts/mpvc/ so the AUR mpvc-git now builds and installs. Is there any action to be performed to clear the "Out of Date" flag at https://aur.archlinux.org/packages/mpvc-git? Thanks.

[m040601]

I've tested again today the PKGBUILD https://aur.archlinux.org/packages/mpvc-git. Seems to be working now.

But it is still missing the README, docs and license. Read the comments there.

Remember that PKGBUILD is still pulling from https://github.com/lwilletts/mpvc/ and not https://github.com/gmt4/mpvc/.

So what you write or do on your (gmt4) README etc is not what the Archuser gets. Unless of course you merge your changes into lwillets repo.

Upstream URL: https://github.com/lwilletts/mpvc

Is there any action to be performed to clear the "Out of Date" flag 

That is up to the AUR maintainer "lwillets" . If logged in to the AUR you should see a "button" or something to update and unmark it.

Nothing much you can do here on github.

Doesnt seem "lwillets" is paying much attention to the PKGBUILD though.

You could eventually ask him to transfer it to you.

If you are an Archlinux user yourself and willing to learn how to properly maintain it, https://wiki.archlinux.org/title/PKGBUILD

And they you can decide which repo it pulls from (gmt4 or lwillets) etc.

Or even best. Have 2 PKGBUILD's one "mpvc-git" for the rolling versions and one "mpvc" for the releases version.

[gmt4]

You made good points, I'll take some time to process them.
Thanks for the feedback and your time.

(PS: regarding the out-of-date in mpvc-git package, it seems that only the one that did flag the package, can unflag it, at least I can't)

[gmt4]

I've reopened the issue, to address the issues related to the mpvc-git AUR package that can be fixed from here.

I'm not the maintainer of the mpvc-git AUR package, nor I plan to be in the near future, so I can't correct the PKGBUILD.
What I can do now, is ship a proper Makefile that least fixes what can be fixed when it gets called by mpvc-git/PKGBUILD package() function.

I've pushed lwilletts#63 that addresses the missing README and LICENSE in mpvc-git, I still have to think about how to ship docs/ in a proper way.

Report back, if you see anything more missing, if it's all good, then I think only the docs/ is missing.

Thanks.

[gmt4]

I've pushed lwilletts#64 that addresses the missing docs/mpv.conf and docs/logbook.html in mpvc-git.

Thanks