configurable tab label truncation style #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right, Middle, or Left elision to make label text fit on tab GUI element.
| @@ -9,6 +9,7 @@ | |||
| #import "PSMYosemiteTabStyle.h" | |||
| #import "PSMTabBarCell.h" | |||
| #import "PSMTabBarControl.h" | |||
| #import "iTermAdvancedSettingsModel.h" | |||
There was a problem hiding this comment.
I don't want iTerm code leaking into PSM code. It really should be in a separate target. This should go up the delegate chain, instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choice of Right, Middle, or Left elision to make label text fit on tab GUI element.
Setting only visible in Preferences / Advanced.
Exposing a bare
intfor the setting is crude. I'm hazily assuming you may add anNSDictionarytype to the advanced settings in the future (mapping to a dropdown in the GUI), which could be made backward-compatible to theintvalue.