Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release action for Carpet Extra and bumping Carpet core version #173

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

altrisi
Copy link
Collaborator

@altrisi altrisi commented Feb 3, 2021

New: As for the Carpet dependency bump, it's just because the new Rules-to-wiki uses a field and noop from it and else the build would fail, the PR look bad, and bad things may happen. Users should still be able to use older core versions with this though, since nothing else references that class. Nothing else on that regard, just the bump. Now as for the Release action:

This PR is basically the equivalent to gnembon/fabric-carpet#650 for Carpet Extra. Only differences with that one will be highlighted in this PR, except for general things.

Fixes people complaining about Curseforge being outdated.
This actually happens quite a lot for extra (last update in CF was in August, poor people), for example, this fixes #172 and fixes #166, but IIRC there were some others related to this, plus tens of comments in CF.

Fixes Rules to Readme making a mess of commits that have to be pulled all the time.

Fixes people not finding rules because they haven't been released yet.

Now, apart from automatically building when a release is pushed as configured in the gradle.properties file, releasing it to Github and releasing it to Curseforge, what extras does this have?

Since there are no Scarpet docs, that job isn't ported, and since here the rules are sent to the readme instead of the wiki, the current rules to readme action has been adapted to fit into the publish release instead, to enjoy only having the bot commit when releasing, not on every push to CarpetExtraSettings.

This PR at the same time moves the RulePrinter.java into the source, as it was done in Carpet some time ago.

And, since Carpet Extra is not published to maven (AFAIK), the publishing step and uploading to the action is skipped.

Now, as in the other PR, this needs the CF_API_TOKEN secret to be set before it will work. The CF release has an extra relations field to mark Carpet as a required dependency. CF release is ofc not tested, but should work in theory, since it's basically the same as Carpet's barring id and name.

Previews: We have two:

  • The almost latest iteration of the action, completely working except for Rules-to-readme (silently fails) (Release | Action run)
  • The (no longer) latest (and included) iteration of the action, with Rules-to-Readme failing only because it's expecting RulePrinter to be on the master branch, which isn't there yet (Release | Action run)
  • The actually latest (and included except for one line required for testing) iteration of the action, with the latest and future-proof Rules-to-wiki (Release | Action run)

NOTE: This PR does NOT include automatic versioning for the version field in the fabric.mod.json. That still has to be done manually, unless it's changed in another commit.

@altrisi altrisi marked this pull request as draft February 4, 2021 15:50
@altrisi

This comment has been minimized.

@altrisi

This comment has been minimized.

@altrisi altrisi marked this pull request as ready for review February 7, 2021 11:56
@altrisi

This comment has been minimized.

@altrisi altrisi marked this pull request as draft February 9, 2021 17:28
@altrisi altrisi marked this pull request as ready for review February 9, 2021 17:37
@altrisi altrisi marked this pull request as draft February 11, 2021 17:16
@altrisi altrisi marked this pull request as ready for review February 11, 2021 17:20
@altrisi altrisi changed the title Release action for Carpet Extra Release action for Carpet Extra and bumping Carpet core version Feb 11, 2021
@gnembon gnembon merged commit 755bcde into gnembon:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.16.5 Version?? Update for minecraft 1.6.5
2 participants