Release action for Carpet Extra and bumping Carpet core version #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: As for the Carpet dependency bump, it's just because the new Rules-to-wiki uses a field and noop from it and else the build would fail, the PR look bad, and bad things may happen. Users should still be able to use older core versions with this though, since nothing else references that class. Nothing else on that regard, just the bump. Now as for the Release action:
This PR is basically the equivalent to gnembon/fabric-carpet#650 for Carpet Extra. Only differences with that one will be highlighted in this PR, except for general things.
Fixes people complaining about Curseforge being outdated.
This actually happens quite a lot for extra (last update in CF was in August, poor people), for example, this fixes #172 and fixes #166, but IIRC there were some others related to this, plus tens of comments in CF.
Fixes Rules to Readme making a mess of commits that have to be pulled all the time.
Fixes people not finding rules because they haven't been released yet.
Now, apart from automatically building when a release is pushed as configured in the
gradle.properties
file, releasing it to Github and releasing it to Curseforge, what extras does this have?Since there are no Scarpet docs, that job isn't ported, and since here the rules are sent to the readme instead of the wiki, the current rules to readme action has been adapted to fit into the publish release instead, to enjoy only having the bot commit when releasing, not on every push to
CarpetExtraSettings
.This PR at the same time moves the
RulePrinter.java
into the source, as it was done in Carpet some time ago.And, since Carpet Extra is not published to maven (AFAIK), the publishing step and uploading to the action is skipped.
Now, as in the other PR, this needs the
CF_API_TOKEN
secret to be set before it will work. The CF release has an extrarelations
field to mark Carpet as a required dependency. CF release is ofc not tested, but should work in theory, since it's basically the same as Carpet's barring id and name.Previews: We have two:
(and included)iteration of the action, with Rules-to-Readme failing only because it's expectingRulePrinter
to be on themaster
branch, which isn't there yet (Release | Action run)NOTE: This PR does NOT include automatic versioning for the
version
field in thefabric.mod.json
. That still has to be done manually, unless it's changed in another commit.