1.21.2/1.21.3 port #333
Merged
1.21.2/1.21.3 port #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
About the tests, looks like Y is off by one in all block positions since last runs. I'll push a change to fix them to your branch in a second. |
|
Thanks, I really haven't messed with Game Test functions to have known where to look. |
altrisi
approved these changes
Nov 14, 2024
alext
added a commit
to alext/carpet-abp
that referenced
this pull request
Nov 15, 2024
Changes taken from gnembon/carpet-extra#333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have a potentially working build of carpet-extra for 1.21.3.
The Game Tests seems to fail, but I tried the dispenser behaviors in game manually, so perhaps it's an issue with the Game Test code.